Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1130

Make track order in Data Management Table logical

    Details

    • Story Points:
      3
    • Sprint:
      Fall 2017

      Description

      Currently, when a new track is added, a row is inserted in the data management table at some random position.

      There is code for ordering the rows, but it is not implemented effectively.

      Current task:
      Fix the existing method to
      a) make slightly more sense,
      b) actually work
      The position of a new track added to the table should be consistent and predictable.

      This ordering is handled by featureTableComparator in DataManagementTableModel.java.
      When datasets are initially passed to DataManagementTableModel functions, the datasets are ordered alphabetically. This order may is then lost when we pass it through a hash map in the function feature2StyleReference.

      Ideally, the order would reflect the order in which tracks were added, but that is a larger scope and a separate issue (see related issues).

        Attachments

          Issue Links

            Activity

            Hide
            ieclabau Ivory Blakley (Inactive) added a comment -

            This is an example of the new row ordering.

            Notice that the top several rows are features from the same group (same folder) and they are ordered alphabetically, which is immediately intuitive.

            The lower rows are from the IGB Quickload set, and some are in a folder "TAIR 10 other annotations" which puts them together as a group in the middle of the other datasets from the same source.

            This is not ideal. But it is better than the previous system which did not enforce any logical row ordering.

            Show
            ieclabau Ivory Blakley (Inactive) added a comment - This is an example of the new row ordering. Notice that the top several rows are features from the same group (same folder) and they are ordered alphabetically, which is immediately intuitive. The lower rows are from the IGB Quickload set, and some are in a folder "TAIR 10 other annotations" which puts them together as a group in the middle of the other datasets from the same source. This is not ideal. But it is better than the previous system which did not enforce any logical row ordering.
            Hide
            ieclabau Ivory Blakley (Inactive) added a comment -

            I submitted a pull request.
            Ann reviewed it and asked for better comments in the code.

            I added comments and I updated the pull request.

            Show
            ieclabau Ivory Blakley (Inactive) added a comment - I submitted a pull request. Ann reviewed it and asked for better comments in the code. I added comments and I updated the pull request.
            Hide
            ieclabau Ivory Blakley (Inactive) added a comment -

            I made the change that Ann requested (variable name changed from newFeatures to theFeatures).
            The branch has been updated and a pull request is waiting.

            Show
            ieclabau Ivory Blakley (Inactive) added a comment - I made the change that Ann requested (variable name changed from newFeatures to theFeatures). The branch has been updated and a pull request is waiting.
            Hide
            ann.loraine Ann Loraine added a comment -

            Reminder: Wait until Jenkins builds the new installer before testing.

            Show
            ann.loraine Ann Loraine added a comment - Reminder: Wait until Jenkins builds the new installer before testing.
            Hide
            mason Mason Meyer (Inactive) added a comment -

            My testing confirms that the Data Management table is now ordering tracks in the logical manner expected. Tracks are grouped with the folders they come from and the tracks are ordered alphabetically within that group. I found no ways to break this functionality and I did not notice any other side effects. Since this issue is resolved, it will now be closed.

            Show
            mason Mason Meyer (Inactive) added a comment - My testing confirms that the Data Management table is now ordering tracks in the logical manner expected. Tracks are grouped with the folders they come from and the tracks are ordered alphabetically within that group. I found no ways to break this functionality and I did not notice any other side effects. Since this issue is resolved, it will now be closed.

              People

              • Assignee:
                mason Mason Meyer (Inactive)
                Reporter:
                ieclabau Ivory Blakley (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: