Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1128

Save As... feature appends extra text that can cause the file name to be invalid

        Details

        • Story Points:
          2
        • Sprint:
          Fall 2017

          Description

          While testing IGBF-1092 I noticed that the Save As... feature is not useable at all on Windows. This is because the filename gets appended with additional text causing the file name to be invalid. This is also happening on Mac, but on Mac the filename is not invalid, but the extra text still gets appended.

          For example, if you try to save a graph file as a bedgraph named "test.bedgraph", IGB will actually save the file as "test.bedgraph.*.bedgraph".

          To reproduce:

          1) Select Arabidopsis thaliana genome - go to start screen and click the Arabidopsis image

          2) Choose Data Access > RNA-Seq > Loraine Lab > Mixed Cold > SM > Graph

          3) Select a graph, zoom in on a region

          4) Click Load Data to load some data

          5) Right-click or CNTRL-click track label and select Save As...

          6) Save a file with the name "test.bedgraph"

          Observe: On Mac = the file actually gets saved as test.bedgraph..bedgraph
          On Windows = the file will not be saved at all and there is an exception in the console.

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1410 Improve file name and file existence checking logic when saving track data

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1149 default file extension for graph tracks

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1162 Duplicate File Extensions shown in the Windows File Chooser "Save as type" drop-down menu

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1092 Save As... (bedgraph) feature uses spaces instead of tabs

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. IGBF-2654 Fix: 'replace' action while saving file

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-1090 Implement saving of all chromosomes when exporting as bedgraph

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                8 older comments
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Which fork and which branch is this? Please add link.

                Show
                ann.loraine Ann Loraine added a comment - Which fork and which branch is this? Please add link.
                Hide
                Permalink
                ieclabau Ivory Blakley (Inactive) added a comment -

                I got it from fork:
                bitbucket.org/jdaly8/integrated-genome-browser

                branch name:
                IGBF-1128

                But I don't see that now on BitBucket.

                Show
                ieclabau Ivory Blakley (Inactive) added a comment - I got it from fork: bitbucket.org/jdaly8/integrated-genome-browser branch name: IGBF-1128 But I don't see that now on BitBucket.
                Hide
                Permalink
                ieclabau Ivory Blakley (Inactive) added a comment -

                I think we should move this issue to "Needs testing" because:
                -**These changes have already been merged into lorainelab/integrated-genome-browser/master.**
                -The main improvement (Files CAN BE saved and they save with the correct file extension) has been tested on several machines.

                Downside:
                There is a side-effect that the pull down menu shows the file extension twice. This side-effect only appears on some Windows computers. We can make a new issue for correcting this with appropriate priority. This new issue should be related to IGBF-1128. And whoever works on it needs to have easy access to a Windows 7 machine.

                Since there is a side-affect that still needs to be addressed, and jumping from 1st level review to Needs Testing is unusual, I'm assigning this to Ann to make that judgement call.

                Show
                ieclabau Ivory Blakley (Inactive) added a comment - I think we should move this issue to "Needs testing" because: -** These changes have already been merged into lorainelab/integrated-genome-browser/master. ** -The main improvement (Files CAN BE saved and they save with the correct file extension) has been tested on several machines. Downside: There is a side-effect that the pull down menu shows the file extension twice. This side-effect only appears on some Windows computers. We can make a new issue for correcting this with appropriate priority. This new issue should be related to IGBF-1128 . And whoever works on it needs to have easy access to a Windows 7 machine. Since there is a side-affect that still needs to be addressed, and jumping from 1st level review to Needs Testing is unusual, I'm assigning this to Ann to make that judgement call.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Go ahead and move it to "Needs Testing" and re-assign to Mason

                Show
                ann.loraine Ann Loraine added a comment - Go ahead and move it to "Needs Testing" and re-assign to Mason
                Hide
                Permalink
                mason Mason Meyer (Inactive) added a comment -

                I tested this story today and it seems that the state is the same as my testing done on April 17, 2017; files are being properly saved as .bedgraph or .gr files on Windows and Mac, but on Windows the file extension is being duplicated in the file chooser's drop-down menu for file type. I looked at the live version (IGB 9.0.0) to see if this was occurring there and it is, meaning that the duplication of the file extension is not a result of any code change while fixing this issue, IGBF-1128. Since this is the case, and since everything is working as expected, I am closing this issue and creating IGBF-1162 to track the duplicate file extensions issue.

                Show
                mason Mason Meyer (Inactive) added a comment - I tested this story today and it seems that the state is the same as my testing done on April 17, 2017; files are being properly saved as .bedgraph or .gr files on Windows and Mac, but on Windows the file extension is being duplicated in the file chooser's drop-down menu for file type. I looked at the live version (IGB 9.0.0) to see if this was occurring there and it is, meaning that the duplication of the file extension is not a result of any code change while fixing this issue, IGBF-1128 . Since this is the case, and since everything is working as expected, I am closing this issue and creating IGBF-1162 to track the duplicate file extensions issue.

                  People

                  • Assignee:
                    mason Mason Meyer (Inactive)
                    Reporter:
                    mason Mason Meyer (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    6 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: