Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Email sent to App submitters after App has been accepted contains wrong link.

      For example)

      quoting--
      Your app has been approved! Here is your app page:

      https://apps.bioviz.org/apps/Super%20Simple%20IGB%20App

      To edit your app page:
      1. Go to https://apps.bioviz.org/apps/Super%20Simple%20IGB%20App
      2. Sign in as aloraine@uncc.edu
      3. Under the "Editor's Actions" on the top-right, choose "Edit this page".

      endquote---

      Note how the App URL contains Bundle_Name, which is wrong. It should be using Bundle_SymbolicName.

      While working on this bug, use global grep to search out every instance of Bundle_Name to make sure that it's being used properly. Recall that previously, Bundle_Name was being used to form an App's URL. We changed it to Bundle_SymbolicName as this is guaranteed to be unique within the IGB ecosystem.

        Activity

        Hide
        rpatil14 Riddhi Jagdish Patil added a comment -

        Code changes are present in branch:
        https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2172#diff

        Testing steps:
        1) Submit an app.
        2) Once the app is accepted by the admin, email is sent to user.
        Check the email link for app url. It should redirect to the app page

        Show
        rpatil14 Riddhi Jagdish Patil added a comment - Code changes are present in branch: https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2172#diff Testing steps: 1) Submit an app. 2) Once the app is accepted by the admin, email is sent to user. Check the email link for app url. It should redirect to the app page
        Hide
        aloraine Ann Loraine added a comment -

        Code looks good. Please submit PR.

        Show
        aloraine Ann Loraine added a comment - Code looks good. Please submit PR.
        Show
        rpatil14 Riddhi Jagdish Patil added a comment - Pull request submitted: https://bitbucket.org/lorainelab/appstore/pull-requests/183/igbf-2172-use-bundle_symbolicname-in-urls/diff cc. Ann Loraine
        Hide
        aloraine Ann Loraine added a comment -

        Merged.

        Show
        aloraine Ann Loraine added a comment - Merged.
        Hide
        prutha Prutha Kulkarni added a comment -

        Riddhi Jagdish Patil, I followed the steps mentioned for testing and tested the fix. Now, I am able to see the Bundle_SymbolicName in the confirmation link instead of a Bundle_Name which redirects user to the respective app page.
        Moving the ticket to DONE.

        Show
        prutha Prutha Kulkarni added a comment - Riddhi Jagdish Patil , I followed the steps mentioned for testing and tested the fix. Now, I am able to see the Bundle_SymbolicName in the confirmation link instead of a Bundle_Name which redirects user to the respective app page. Moving the ticket to DONE.

          People

          • Assignee:
            rpatil14 Riddhi Jagdish Patil
            Reporter:
            aloraine Ann Loraine
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile