Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2005

Rename version to Bundle_Version to make it more meaningful

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      • Refactor the app store code base to rename the version variable to bundle_version to make it more meaningful and to let the developers know that the version is Bundle-Version of MANIFEST.MF file
      • Change the version field size from text field to char field which shows up in admin UI.

        Activity

        Show
        noor91zahara Noor Zahara added a comment - Code change can be found https://bitbucket.org/rpatil14/appstore_refactoring/branch/IGBF-2005#diff
        Hide
        aloraine Ann Loraine added a comment -

        Merged to master. Commence testing once all issues from epic https://jira.transvar.org/browse/IGBF-1996 are merged.

        Show
        aloraine Ann Loraine added a comment - Merged to master. Commence testing once all issues from epic https://jira.transvar.org/browse/IGBF-1996 are merged.
        Hide
        aloraine Ann Loraine added a comment -

        Please commence testing.

        Show
        aloraine Ann Loraine added a comment - Please commence testing.
        Hide
        noor91zahara Noor Zahara added a comment -

        Bug fix has been made. Below is the code change

        https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2005-1#diff

        Show
        noor91zahara Noor Zahara added a comment - Bug fix has been made. Below is the code change https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2005-1#diff
        Hide
        aloraine Ann Loraine added a comment - - edited

        Code is fine and feature is working as expected. Please submit PR.

        Show
        aloraine Ann Loraine added a comment - - edited Code is fine and feature is working as expected. Please submit PR.
        Hide
        rpatil14 Riddhi Jagdish Patil added a comment -

        Tested the code changes by deploying latest code changes on https://dev-appstore-6.bioviz.org
        Testing steps:
        1) Open admin panel -> Apps -> Select any app to open app details.
        Check that the version label is replaced with "Bundle Version" and the char field for version is replaced with input text field

        2) Open admin panel -> App pendings -> Select any app to open app details.
        Check that the version label is replaced with "Bundle Version" and the char field for version is replaced with input text field

        Marking ticket as done

        Show
        rpatil14 Riddhi Jagdish Patil added a comment - Tested the code changes by deploying latest code changes on https://dev-appstore-6.bioviz.org Testing steps: 1) Open admin panel -> Apps -> Select any app to open app details. Check that the version label is replaced with "Bundle Version" and the char field for version is replaced with input text field 2) Open admin panel -> App pendings -> Select any app to open app details. Check that the version label is replaced with "Bundle Version" and the char field for version is replaced with input text field Marking ticket as done

          People

          • Assignee:
            noor91zahara Noor Zahara
            Reporter:
            rpatil14 Riddhi Jagdish Patil
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile