Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2000

Rename fullname variable to Bundle_Name and remove name variable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      • Refactor the app store code base to rename the fullname variable to bundle_name to make it more meaningful and to let the developers know that the symbolic name is Bundle-SymbolicName of MANIFEST.MF file
      • Remove the name variable as it will no longer be used and Bundle_Name will be used instead, but only in user-facing places

        Activity

        Hide
        sameer Sameer Shanbhag added a comment - - edited

        Pull Request Updated with the Requirement Specified:

        https://bitbucket.org/rpatil14/appstore_riddhi/pull-requests/2/igbf-2000-refactoring-fullname-to/diff

        Noor Zahara Riddhi Jagdish Patil
        Please check if your commits adhere with the following requirements:

        We are using the same capitalization convention as the MANIFEST.MF variable to signal to developers where such variables are coming from.

        All other variables use the python convention word_[word_]word. (I’m not sure if this style of variable naming has a name the same way camel case variables do.)

        So far these fields/variable names are coming from the MANIFEST.MF:

        Bundle_Name
        Bundle_SymbolicName
        Bundle_Description
        Bundle_Version
        However I just noticed the title of IGBF-2000 gives variable name Bundle_name, but it should have been Bundle_Name. I will fix it now. Sorry to waste your time on that.

        You might be able to do a global replace using sed and xargs, for example:

        find . -type f -exec grep -Iq . {} \; -print | xargs -I FILE sed -i s/fullname/Bundle_name/g FILE
        Refs:
        https://stackoverflow.com/questions/4767396/linux-command-how-to-find-only-text-files
        https://www.digitalocean.com/community/tutorials/the-basics-of-using-the-sed-stream-editor-to-manipulate-text-in-linux

        Show
        sameer Sameer Shanbhag added a comment - - edited Pull Request Updated with the Requirement Specified: https://bitbucket.org/rpatil14/appstore_riddhi/pull-requests/2/igbf-2000-refactoring-fullname-to/diff Noor Zahara Riddhi Jagdish Patil Please check if your commits adhere with the following requirements: We are using the same capitalization convention as the MANIFEST.MF variable to signal to developers where such variables are coming from. All other variables use the python convention word_ [word_] word. (I’m not sure if this style of variable naming has a name the same way camel case variables do.) So far these fields/variable names are coming from the MANIFEST.MF: Bundle_Name Bundle_SymbolicName Bundle_Description Bundle_Version However I just noticed the title of IGBF-2000 gives variable name Bundle_name, but it should have been Bundle_Name. I will fix it now. Sorry to waste your time on that. You might be able to do a global replace using sed and xargs, for example: find . -type f -exec grep -Iq . {} \; -print | xargs -I FILE sed -i s/fullname/Bundle_name/g FILE Refs: https://stackoverflow.com/questions/4767396/linux-command-how-to-find-only-text-files https://www.digitalocean.com/community/tutorials/the-basics-of-using-the-sed-stream-editor-to-manipulate-text-in-linux
        Hide
        aloraine Ann Loraine added a comment -

        Merged to master branch in team repository. Please test after refactoring issues are merged.

        Show
        aloraine Ann Loraine added a comment - Merged to master branch in team repository. Please test after refactoring issues are merged.
        Hide
        aloraine Ann Loraine added a comment -

        Please commence testing.

        Show
        aloraine Ann Loraine added a comment - Please commence testing.
        Hide
        rpatil14 Riddhi Jagdish Patil added a comment - - edited

        Working as expected.
        Marking this ticket as Done

        cc. Ann Loraine, Sameer Shanbhag

        Show
        rpatil14 Riddhi Jagdish Patil added a comment - - edited Working as expected. Marking this ticket as Done cc. Ann Loraine , Sameer Shanbhag

          People

          • Assignee:
            sameer Sameer Shanbhag
            Reporter:
            rpatil14 Riddhi Jagdish Patil
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile