Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      The IGB App recommended build pipeline creates MANIFEST.MF file with the attributes:

      • Bundle-Name - human-friendly, user-facing App title, e.g., "Merge Annotation Track Operator" or "ProtAnnot" or "My New App"
      • Bundle-SymbolicName - used by OSGi run-time, e.g., merge-annotation-track-operator
      • Bundle-Version - used by OGGi run-time. IGB Apps must use semantic versioning syntax, e.g., 10.1.10 (major.minor.micro)

      Currently, App Store is using Bundle-Name to build paths to files in S3 and URLs to Apps pages. This creates many problems. For example, this make it hard to change the human-friendly title of an App after it has been submitted. This is bad because anything user-facing ought to be easy to change and improve.

      However, we need some way to create predictable paths to files and Apps.

      Instead of using Bundle-Name to create paths, let's use Bundle-SymbolicName instead. This value, together with Bundle-Version, is already being used by OSGi to distinguish and resolve bundles. We can do the same in App Store.

      Let's re-factor the internal App Store infrastructure to no longer use Bundle-Name for anything other than provide user-friendly text to display to users.

      For example, storage page for released apps should look like:

      • /media/[Bundle-SymbolicName]/releases/[Bundle-Version]/[Bundle-SymbolicName]-[version].jar

      New URLs for Apps should look like:

      [domain]/apps/[Bundle-SymbolicName]

      In addition, let's modify model fields and variable names to make it more clear where they came from and what they mean.

        Issue Links

          Activity

          Hide
          aloraine Ann Loraine added a comment - - edited

          If this makes sense to do in this current branch, can you change this line:

          • Msgs.add_msg(app_name + ' has been installed! Go to IGB to use it.', 'success');"

          in

          • ./static/apps/js/app_page.js:

          I noticed that when I installed the Merge Annotation Operator using dev-appstore-6, the confirmation message read:

          • "mergeannotationtrackoperator has been installed! Go to IGB to use it."

          which is showing the older-style app name.

          It would be better if it could display this instead:

          • "Merge Annotation Track Operator has been installed! Go to IGB to use it."

          It would be better to use the Bundle_Name itself - with punctuation, capital letters, etc. matching what is shown on the App Page itself.

          Show
          aloraine Ann Loraine added a comment - - edited If this makes sense to do in this current branch, can you change this line: Msgs.add_msg(app_name + ' has been installed! Go to IGB to use it.', 'success');" in ./static/apps/js/app_page.js: I noticed that when I installed the Merge Annotation Operator using dev-appstore-6, the confirmation message read: "mergeannotationtrackoperator has been installed! Go to IGB to use it." which is showing the older-style app name. It would be better if it could display this instead: "Merge Annotation Track Operator has been installed! Go to IGB to use it." It would be better to use the Bundle_Name itself - with punctuation, capital letters, etc. matching what is shown on the App Page itself.
          Hide
          aloraine Ann Loraine added a comment -

          After deciding on whether to make the above change, please submit PR.

          Show
          aloraine Ann Loraine added a comment - After deciding on whether to make the above change, please submit PR.
          Hide
          rpatil14 Riddhi Jagdish Patil added a comment -

          Changed app_name to app_Bundle-Name for the UI pop-up messages.
          Code is deployed on https://dev-appstore-6.bioviz.org
          Submitted pull request:
          https://bitbucket.org/lorainelab/appstore/pull-requests/121/igbf-1992-issues/diff
          cc. Ann Loraine

          Show
          rpatil14 Riddhi Jagdish Patil added a comment - Changed app_name to app_Bundle-Name for the UI pop-up messages. Code is deployed on https://dev-appstore-6.bioviz.org Submitted pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/121/igbf-1992-issues/diff cc. Ann Loraine
          Hide
          aloraine Ann Loraine added a comment -

          Merged to master but not yet deployed to master branch dev appstore 2.

          Show
          aloraine Ann Loraine added a comment - Merged to master but not yet deployed to master branch dev appstore 2.
          Hide
          svallapu Sai Charan Reddy Vallapureddy added a comment -

          Tested in appstore2. Working as expected. Moving it to done.

          Show
          svallapu Sai Charan Reddy Vallapureddy added a comment - Tested in appstore2. Working as expected. Moving it to done.

            People

            • Assignee:
              rpatil14 Riddhi Jagdish Patil
              Reporter:
              aloraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile