Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1312

Improve error message shown upon opening a file before selecting a genome version

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Story Points:
      1
    • Sprint:
      Winter 2018 Sprint 3, Spring 2019 Sprint 1

      Description

      If you open a file in IGB without selecting a genome, you can view the file but there is no genome sequence.
      So the Load Sequence option probably shouldn't be enabled.
      As it is, you can click the Load Sequence button, and you get an error that says:

      "Couldn't locate the partial sequence. Try loading the full sequence."

      This error message does not make sense given the context. (In other contexts it does make sense.)

      The error message for this particular workflow should be more informative. Or, the button "Load Sequence" should not be active when no sequence file is available.

      The task:

      • Investigate and identify files/code involved.
      • Determine: is there any way for IGB to determine if the reference genome sequence is available to load before showing that message?
      • Design a solution that improves user experience.

        Issue Links

          Activity

          Hide
          aloraine Ann Loraine added a comment -

          Test file - download and load without 1st selecting a genome:

          Show
          aloraine Ann Loraine added a comment - Test file - download and load without 1st selecting a genome: http://igbquickload.org/quickload/A_thaliana_Jun_2009/Araport11.bed.gz
          Hide
          nfreese Nowlan Freese added a comment -

          This class may be important: com.affymetrix.igb.view.load.GeneralLoadView

          Show
          nfreese Nowlan Freese added a comment - This class may be important: com.affymetrix.igb.view.load.GeneralLoadView
          Hide
          aloraine Ann Loraine added a comment -

          Better error message?
          "A genome sequence has not been selected. Loading sequence data is not possible."

          Show
          aloraine Ann Loraine added a comment - Better error message? "A genome sequence has not been selected. Loading sequence data is not possible."
          Hide
          rpatil14 Riddhi Jagdish Patil added a comment - - edited

          Issue:- To improve the error message in case of loading sequence data from a file which doesn't have the genome data.

          Files changed:-
          core/igb/src/main/java/com/affymetrix/igb/view/load/GeneralLoadView.java

          Testing scenarios:-
          Drag and drop file in IGB application -
          If no genome is selected, on clicking Load Sequence button you will get an error message "A genome sequence has not been selected.Loading sequence data is not possible."

          Testing results:-
          Please check the attached test result for each test scenario.

          Code changes:-
          https://bitbucket.org/rpatil14/riddhifork-igb/branch/IGBF-1312#diff

          Show
          rpatil14 Riddhi Jagdish Patil added a comment - - edited Issue:- To improve the error message in case of loading sequence data from a file which doesn't have the genome data. Files changed:- core/igb/src/main/java/com/affymetrix/igb/view/load/GeneralLoadView.java Testing scenarios:- Drag and drop file in IGB application - If no genome is selected, on clicking Load Sequence button you will get an error message "A genome sequence has not been selected.Loading sequence data is not possible." Testing results:- Please check the attached test result for each test scenario. Code changes:- https://bitbucket.org/rpatil14/riddhifork-igb/branch/IGBF-1312#diff
          Hide
          nfreese Nowlan Freese added a comment -

          1st level review:
          Functions correctly, if no genome has been selected, clicking the Load Sequence button brings up the error message "A genome sequence has not been selected.Loading sequence data is not possible."

          Show
          nfreese Nowlan Freese added a comment - 1st level review: Functions correctly, if no genome has been selected, clicking the Load Sequence button brings up the error message "A genome sequence has not been selected.Loading sequence data is not possible."
          Show
          rpatil14 Riddhi Jagdish Patil added a comment - Pull request submitted. https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/659/igbf-1312-to-improve-the-error-message-in/diff
          Hide
          rpatil14 Riddhi Jagdish Patil added a comment -

          Windows testing successful

          Show
          rpatil14 Riddhi Jagdish Patil added a comment - Windows testing successful
          Hide
          Jill Jill Jenkins (Inactive) added a comment -

          MacOS testing successful.

          Show
          Jill Jill Jenkins (Inactive) added a comment - MacOS testing successful.
          Hide
          svallapu Sai Charan Reddy Vallapureddy added a comment -

          Linux testing successful.

          Show
          svallapu Sai Charan Reddy Vallapureddy added a comment - Linux testing successful.

            People

            • Assignee:
              rpatil14 Riddhi Jagdish Patil
              Reporter:
              ieclabau Ivory Blakley (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile