Details
-
Type:
Documentation
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:0.25
-
Sprint:Fall 2018 Sprint 2
Description
In the IGB user's guide,
https://wiki.transvar.org/display/igbman/Home
We tell people to cite this paper:
Freese NH, Norris DC, Loraine AE.
Integrated genome browser: visual analytics platform for genomics.
Bioinformatics. Epub: 2016, March 16; 1-7. 10.1093/bioinformatics/btw069
http://bioinformatics.oxfordjournals.org/content/early/2016/04/04/bioinformatics.btw069
In the Help > About IGB window in IGB, we say to cite this paper:
Nicol JW, Helt GA, Blanchard SG Jr, Raja A, Loraine AE. The Integrated Genome Browser: free software for distribution and exploration of genome-scale datasets. Bioinformatics. 2009 25(20):2730-1.
Make IGB Help window match the wiki.
Attachments
Activity
Updated citation info as mentioned in the description.
Please find the below link to my commit:
https://bitbucket.org/srishtitiwari/integrated-genome-browser/commits/595a7905c4e94621d7acd32bd2ec17e8c36d7baa
Unassigned myself and moving it for 1st Level Review.
First level review.
Git review:
Single commit, for a single change. Apprpriate message. Good!
Code review:
Notice that the original code is broken up into 4 lines so that it does not exceed 80 characters (your editor probably has a guideline to help with this).
This does not make a functional difference, but the new code is harder to read.
Insert some reasonable splits in the line so the file is easy to read without scrolling.
Functional review:
The new information is correct. The link works. All is well.
_______________________
I am reassigning this to Srishti to improve readability.
That should be a quick change, and a quick re-review, before the pull request.
Thank you for your feedback, Ivory!
Reformatted the code.
Looks Good!
Submit a pull a request.
Merged into master.
After testing this story I can confirm that the citation info in the Help > About IGB window in IGB matches to what is there in the Wiki. The hyperlink is valid and navigates to the same page as the link in the wiki does.
This has been tested in Windows and Linux and is functioning as expected.
No side effects observed.
Since the issue is now resolved it will now be closed.
Ideal 1st issue for project newbie